Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Add Single.ignoreElement, deprecate toCompletable #5957

Merged
merged 3 commits into from
Apr 13, 2018
Merged

2.x: Add Single.ignoreElement, deprecate toCompletable #5957

merged 3 commits into from
Apr 13, 2018
+39 −4

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Apr 12, 2018 •
edited
Loading

Rename-deprecate Single.toCompletable to ignoreElement to be in line with the same operator in the other classes and also indicate more clearly in the method name that it ignores the element.

In addition, the marbles have been updated on both Single and Maybe of this operator.

image
image

@akarnokd akarnokd added this to the 2.2 milestone Apr 12, 2018
@codecov
Copy link

codecov bot commented Apr 12, 2018 •
edited
Loading

Codecov Report

Merging #5957 into 2.x will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5957      +/-   ##
============================================
+ Coverage     98.23%   98.26%   +0.02%     
- Complexity     6016     6018       +2     
============================================
  Files           656      656              
  Lines         44036    44037       +1     
  Branches       6100     6100              
============================================
+ Hits          43259    43272      +13     
+ Misses          238      226      -12     
  Partials        539      539
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 171 <0> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <100%> (ø) 143 <1> (+1) ⬆️
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 91.5% <0%> (-3.27%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 91.79% <0%> (-2.24%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 96.66% <0%> (-1.67%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 94.11% <0%> (-1.61%) 5% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eee45e0...94addf9. Read the comment docs.

vanniktech
vanniktech reviewed Apr 12, 2018
View reviewed changes
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We deprecate a method that's stable and then add a new one that should be used that's experimental.

Does not seem right to me.

@akarnokd
Copy link
Member Author

I'd be completely fine with ignoreElement being standard right away.

@vanniktech
Copy link
Collaborator

Then let's do it.

@akarnokd akarnokd merged commit 8690235 into ReactiveX:2.x Apr 13, 2018
@akarnokd akarnokd deleted the SingleIgnoreElement branch April 13, 2018 07:53
@akarnokd akarnokd mentioned this pull request Apr 23, 2018
Closed
@jared-bot jared-bot mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
2.x Cleanup Documentation
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @vanniktech